Added args and exclude_types to hook type
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joedevivo
force-pushed
the
args-and-exclude_types
branch
2 times, most recently
from
9534357
to
72bce63
Compare
joedevivo
force-pushed
the
args-and-exclude_types
branch
from
72bce63
to
29f062e
Compare
sandydoo
requested changes
Apr 1, 2024
There was a problem hiding this comment.
👍 to bothexclude_types and args.
Regarding shftm, args is a good fallback/escape-hatch when a hook is missing module options, but we shouldn't make a habit of setting a default of anything other than [].
Let's maybe expose this as hooks.shftm.settings.simplify and set it to true by default for backwards-compatibility? Perhaps in a separate PR?
| type = types.listOf types.str; | ||
| description = lib.mdDoc | ||
| '' | ||
| List of file types to exclude. See [Filtering files with types](https://pre-commit.com/#plugins). |
There was a problem hiding this comment.
Suggested change
| List of file types to exclude. See [Filtering files with types](https://pre-commit.com/#plugins). | |
| List of file types to exclude. See [Filtering files with types](https://pre-commit.com/#filtering-files-with-types). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating new hooks allows for
argsandexclude_types.In particular, I wanted to configure
shfmtto not force the-sflag. I changed the default configuration forshfmtto haveargs = [ "-s" ]to not break anything for anybody, but it allows me to disable it, and add other flags.