feat(hooks): add additional cargo-options #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sivizius
force-pushed
the
add-cargo-options
branch
from
a3aa953
to
c00122d
Compare
sivizius
force-pushed
the
add-cargo-options
branch
from
c00122d
to
29a92b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add additional cargo-hooks (cargo-bench, cargo-doc and cargo-test) as well as additional options. I did not implement all possible options, because e.g.
--quietis not really useful in a git-hook. If you do not agree, I can implement them too. The lack of some options requires implementing custom cargo-hooks in my setup, which is somewhat annoying.This PR will deprecate
allFeaturesanddenyWarningsof clippy with a warning. The former was renamed toall-featureswhile the latter can be achieved withdeny = [ "warnings" ];.manifest-pathis an option in each hook, which defaults to the global settingrust.cargoManifestPath, which makes it overridable. The additional hooks might not be very useful, because they will take some time, but someone might find them useful and it was possible due to the generic implementation. Additional cargo-hooks can be added quite easily now.