feat: Use caddy's internal Proxy protocol module #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #166 +/- ##
==========================================
- Coverage 18.90% 18.34% -0.57%
==========================================
Files 30 30
Lines 1063 1063
==========================================
- Hits 201 195 -6
- Misses 861 867 +6
Partials 1 1 ☔ View full report in Codecov by Sentry. |
mavimo
reviewed
Oct 30, 2023
mavimo
reviewed
Oct 30, 2023
Also deprecated the one we have as it's redundant with the one included in caddy. Because it's the same library behind, I do not expect any breaking change.
mavimo
force-pushed
the
embraser01/use-caddy-proxymodule
branch
from
bb1a8ae
to
0334775
Compare
mavimo
approved these changes
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also deprecated the one we have as it's redundant with the one included in caddy and people should use the one provided by caddy.
Because it's the same library behind, I do not expect any breaking change.
I'll let it in draft until the new proxyprotol module is merged and released in caddy (caddyserver/caddy#5915)