Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added types exports #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added types exports #39

wants to merge 1 commit into from

Conversation

stagas
Copy link

@stagas stagas commented Nov 8, 2021

This PR adds types exports.

In cases where I want to programmatically prepare different configurations in a different context and then passing them to add(), cycle(), complete() etc... I need to have access to the user-facing types by the library. I went a little further and figured which types from each file are "public api" so I added them to exports, basically completing work that was already happening, and replaced the main entry exports with * (asterisk) for the add, cycle, etc. modules. This would take care the fact that whatever is exported by these public apis is also exported in the main entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant