Add coverage to workflow #51

[lorenzocelli]

Add coverage report using

• irongut/CodeCoverageSummary
• marocchino/sticky-pull-request-comment

[lorenzocelli]

With this action it is currently not possible to include the badge in the readme.

@siliconlad do we want the coverage to fail under a certain threshold?

[siliconlad]

With this action it is currently not possible to include the badge in the readme.

Is it silly to get the bot to overwrite the badge in the README every time (or on merge)?

[siliconlad]

@siliconlad do we want the coverage to fail under a certain threshold?

Is there a reason not to set it at 100%?

[lorenzocelli]

Is there a reason not to set it at 100%?

I don't see any. I will have it fail then

[lorenzocelli]

Is it silly to get the bot to overwrite the badge in the README every time (or on merge)?

I don't think it is worth the effort, but if we really want the badge we can do it

[github-actions]

Package	Line Rate	Complexity	Health
.	98%	0	✔
Summary	98% (251 / 257)	0	✔

[github-actions]

Package	Line Rate	Complexity	Health
.	98%	0	✔
Summary	98% (251 / 257)	0	✔

[siliconlad]

Is it silly to get the bot to overwrite the badge in the README every time (or on merge)?

I don't think it is worth the effort, but if we really want the badge we can do it

Let's leave it then 👍

[siliconlad]

Do we need the bot vs just a job that fails? I wonder how annoying the bot will become.

[lorenzocelli]

Let's get rid of the bot 🤖🔫

[lorenzocelli]

The non-tested code we have is the following. In parameter_schema.py:

class ParameterSchema:

    @staticmethod
    def matches(parameter: Parameter) -> bool:
        raise NotImplementedError()  # <---- this line

    def _get_type(self) -> Union[str, Parameter.empty]:
        return Parameter.empty  # <---- this line

Maybe it can be solved with abstract classes.
In schema.py:

# ---- this method ----
def SaveGPTEnabled(module: ModuleType, path: str, schema_type: SchemaType = SchemaType.API):
    schemas = FindGPTEnabledSchemas(module, schema_type)
    json.dump(schemas, open(path, "w"))

# ...

class _GPTEnabled:
    # ...

    # ---- this method ----
    def gpt_enabled(self) -> bool:
        return True

# ...

class FunctionSchema:

    # ...

    def _get_parameters_schema(self, schema_type: SchemaType) -> dict:
        schema = {"type": "object"}
        
        if not self.parameter_schemas and schema_type == SchemaType.API:
            # Skip properties
            return schema  # <---- this line

[siliconlad]

Lowered the threshold to 95%.