Add tgis timeout #358
Merged
Add tgis timeout #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
gkumbhat
requested review from
alex-jw-brooks,
evaline-ju,
gabe-l-hart,
tharapalanivel and
Ssukriti
as code owners
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
Signed-off-by: gkumbhat <kumbhat.gaurav@gmail.com>
evaline-ju
approved these changes
May 17, 2024
| return StubTGISClient.tokenize(request) | ||
|
|
||
| @staticmethod | ||
| def unary_generate(request): | ||
| def unary_generate(request, **kwargs): |
There was a problem hiding this comment.
Interesting, the args here look pretty different overall than the TGISClient (i.e. no request is passed there, and timeout wouldn't be coming through these functions anyway)
There was a problem hiding this comment.
it does.. I think there is some mismatch in terms of how the tests have been written. I need to revisit and refactor the tests a bit I think, but punting on that for getting the fix out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes