Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-3279: Cake runner arguments as build script arguments #4142

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

GH-3279: Cake runner arguments as build script arguments #4142

wants to merge 11 commits into from

Commits on Oct 30, 2023

  1. Implemented tests to assert correct behaviour, currently broken due t… 

    …o spectre.console reference being 0.46.0
    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    84dc529 View commit details
    Browse the repository at this point in the history

  2. Unit tests, fully implemented

    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    ee414b2 View commit details
    Browse the repository at this point in the history

  3. config.Settings.ConvertFlagsToRemainingArguments = true;

    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    59b5398 View commit details
    Browse the repository at this point in the history

  4. Updated tests, all green

    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    3e20144 View commit details
    Browse the repository at this point in the history

  5. Implemented tests to assert correct behaviour

    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    9ef3b70 View commit details
    Browse the repository at this point in the history

  6. Upgraded spectre.console to 0.47 to get access to the new IConfigurat… 

    …or settings property, ConvertFlagsToRemainingArguments
    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    29de990 View commit details
    Browse the repository at this point in the history

  7. Minor change to reprompt the build (to see if it passes this time)

    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    1ca90c5 View commit details
    Browse the repository at this point in the history

  8. Exclude newly introduced tests to check if they are causing the perfo… 

    …rmance problems when the integration tests are run after pushing to the PR
    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    87fdd26 View commit details
    Browse the repository at this point in the history

  9. Revert "Minor change to reprompt the build (to see if it passes this … 

    …time)"

This reverts commit ba4e83f.
    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    91c5dbb View commit details
    Browse the repository at this point in the history

  10. Revert "Exclude newly introduced tests to check if they are causing t… 

    …he performance problems when the integration tests are run after pushing to the PR"

This reverts commit 3b51ae7.
    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    e854873 View commit details
    Browse the repository at this point in the history

  11. Updated unit test to fix broken build after rebase

    @FrankRay78
    FrankRay78 committed Oct 30, 2023
    Configuration menu
    Copy the full SHA
    09cf0d2 View commit details
    Browse the repository at this point in the history