new alias: GitSetLibGit2NativeLibraryPathToIncluded & GitEnableLogging #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalberger
requested changes
Feb 25, 2024
.github/workflows/build.yml
Outdated
| @@ -14,7 +14,7 @@ jobs: | |||
| strategy: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu-20.04, ubuntu-latest, macos-latest, windows-2019, windows-2022] | |||
| os: [ubuntu-20.04, ubuntu-latest, macos-12, macos-13, macOS-13-arm64, windows-2019, windows-2022] | |||
There was a problem hiding this comment.
I can't see a macOS-13-arm64 agent mentioned at https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners.
The macos-13-xlarge agent uses an ARM processor: https://docs.github.com/en/actions/using-github-hosted-runners/about-larger-runners/about-larger-runners#about-macos-larger-runners
There was a problem hiding this comment.
Smaller agents which are free don't seem to be available yet: actions/runner-images#8439 (comment)
There was a problem hiding this comment.
@pascalberger I reverted the changes I did to the CI machines. I have not tried FlyCI, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitEnableLoggingenables the git logging in LibGit2Sharp and routes the log messages into Cake. NOt sure, if we need this, but it felt like a nice addition while I was looking through the configuration-options of LibGit2Sharp.GitSetLibGit2NativeLibraryPathToIncludedcalculates the path to the included native libGit2 libraries and configures that path asNativeLibraryPathof LibGit2Sharp.If this works for all systems, we could also drop the use of the extra call and configure
NativeLibraryPathautomatically. (This would actually be my preferred solution, I think. CallingGitSetLibGit2NativeLibraryPathToIncluded()as a first statement on every build that uses Cake.Git feels a bit cumbersome.)