This repository has been archived by the owner on May 16, 2023. It is now read-only.
Replacement of SNS generated with native entity #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calavera
suggested changes
Mar 13, 2022
There was a problem hiding this comment.
Don't forget to add SNS to the list of modules that the generator ignores, so the next time someone runs it, the file is not recreated again:
https://github.com/LegNeato/aws-lambda-events/blob/master/aws_lambda_events_codegen/src/main.rs#L48
|
I totally overlooked that. Exclusion added. |
calavera
approved these changes
Mar 13, 2022
calavera
suggested changes
Mar 13, 2022
There was a problem hiding this comment.
@brentlemons it looks like there is some formatting issues in this code, you can fix them by running cargo fmt
This was referenced Apr 29, 2022
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created struct definitions of SNS to replace the go generated structs.
The go generated definitions included additional structs for specific message types defined by CloudWatch events. These were added in the go events library via PR #296. These do not exist in the Java or C# libraries. The go PR even says they are duplicated from the CloudWatch module. Excluding in favor of user using the proper CloudWatch defined structs and not duplicating.