fix: meeting ended and started webhooks trigger #14864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
May 1, 2024 12:57
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 321 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 05/10/2024 01:50:19pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: b6edd27 Started: 05/10/2024 01:46:15pm UTC
|
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2 • Retry 1 • Initial Attempt |
3.93% (12)12 / 305 runsfailed over last 7 days |
19.67% (60)60 / 305 runsflaked over last 7 days |
|
Teams - NonOrg -- future Can create a booking for Round Robin EventType
Retry 2 • Retry 1 • Initial Attempt |
6.89% (21)21 / 305 runsfailed over last 7 days |
30.82% (94)94 / 305 runsflaked over last 7 days |
📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats
Retry 1 • Initial Attempt |
0% (0)0 / 296 runsfailed over last 7 days |
37.84% (112)112 / 296 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
MEETING_ENDED, MEETING_STARTED should create/remove scheduledWebhookTriggers for existing bookings
Retry 1 • Initial Attempt |
8.33% (1)1 / 12 runfailed over last 7 days |
50% (6)6 / 12 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can verify the newly added secondary email
Retry 2 • Retry 1 • Initial Attempt |
1.46% (5)5 / 342 runsfailed over last 7 days |
20.76% (71)71 / 342 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace)
Retry 1 • Initial Attempt |
0% (0)0 / 299 runsfailed over last 7 days |
55.85% (167)167 / 299 runsflaked over last 7 days |
📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced
Retry 1 • Initial Attempt |
18.15% (57)57 / 314 runsfailed over last 7 days |
39.49% (124)124 / 314 runsflaked over last 7 days |
📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Routing Forms Seeded Routing Form Router URL should work
Retry 1 • Initial Attempt |
0% (0)0 / 297 runsfailed over last 7 days |
12.12% (36)36 / 297 runsflaked over last 7 days |
dosubot
bot
added
bookings
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/07/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
reviewed
May 9, 2024
Udit-takkar
reviewed
May 9, 2024
zomars
approved these changes
May 10, 2024
There was a problem hiding this comment.
Nice job @CarinaWolli. Seems like the failed e2e is an old one. LGTM.
| }, | ||
| }); | ||
|
|
||
| expect(scheduledTriggersAfterDisabling.length).toBe(0); |
| fetchPromises.push( | ||
| fetch(job.subscriberUrl, { | ||
| method: "POST", | ||
| body: job.payload, |
There was a problem hiding this comment.
Isn't the body supposed to be of the below form ?
"triggerEvent": "",
"createdAt": "",
"payload": {}
}
Check #15033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This fixes several issues with the Meeting ended and Meeting started trigger. The original issue was that if one booking was canceled, all scheduled triggers for that webhook, also the ones that were not related to the canceled booking, were deleted. This is why the meeting ended/started trigger didn't always trigger.
Cleans up some old code. Since we use
WebhookScheduledTriggerswith a corn job,scheduledJobsare not needed anymore.Fixes #14685
How should this be tested?
You can also test: