fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

hariombalhara · 2024-05-08T08:04:00Z

What does this PR do?

Fixes #14936
Fixes CAL-3661

Fixes the origin for Cal.com used in SEO. It fixes two things automatically

Canonical
og:url

Status

Will be writing a test for this

Screenshots for the branch

Profile Page - Team

Profile Page - User

Event Page(BookerSeo)

For a non-org event it is same as earlier

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Simply view the source-code for Profile Pages and Event Type pages for Team and User events in an org

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works

vercel · 2024-05-08T08:04:05Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
ai	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2024 9:00am

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
cal	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 9:00am
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 20, 2024 9:00am

github-actions · 2024-05-08T08:04:13Z

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

hariombalhara · 2024-05-08T08:04:16Z

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935 👈
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @hariombalhara and the rest of your teammates on Graphite

github-actions · 2024-05-08T08:15:08Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page	Size (compressed)	First Load	% of Budget (`350 KB`)
`/[user]`	`114.64 KB`	343.22 KB	98.06% (🟡 +2.11%)
`/[user]/embed`	`114.65 KB`	343.23 KB	98.07% (🟡 +2.10%)
`/booking/[uid]`	`233.23 KB`	461.81 KB	131.95% (🟡 +2.02%)
`/booking/[uid]/embed`	`233.24 KB`	461.82 KB	131.95% (🟡 +2.02%)
`/video/[uid]`	`295.84 KB`	524.42 KB	149.83% (🟡 +1.37%)

Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

linear · 2024-05-08T08:15:48Z

CAL-3661 Wrong canonical link in source for org events

deploysentinel · 2024-05-08T08:15:53Z

Current Playwright Test Results Summary

✅ 319 Passing - ❌ 2 Failing - ⚠️ 11 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 05/20/2024 09:10:45am UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: a0fa3c8

Started: 05/20/2024 09:08:11am UTC

❌ Failures

📄 apps/web/playwright/hash-my-url.e2e.ts • 1 Failure

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes

hash my url generate url hash
Retry 2 • Retry 1 • Initial Attempt

Error: locator.fill: Error: strict mode violation: locator('[data-testid=event-title]')...

locator.fill: Error: strict mode violation: locator('[data-testid=event-title]') resolved to 2 elements:
    1) <input id=":r33:" required="" name="title" placeholder=…/> aka getByTestId('event-title').first()
    2) <input id=":r40:" required="" name="title" placeholder=…/> aka getByTestId('event-title').nth(1)

=========================== logs ===========================
waiting for locator('[data-testid=event-title]')
============================================================

6.76% (15)

15 / 222 runs
failed over last 7 days

28.38% (63)

63 / 222 runs
flaked over last 7 days

📄 packages/embeds/embed-react/playwright/tests/basic.e2e.ts • 1 Failure

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
React Embed Element Click Popup should verify that the iframe got created with correct URL - namespaced Retry 2 • Retry 1 • Initial Attempt Error: Expected to provide an iframe, got null `Expected to provide an iframe, got null`	18.64% (44) 44 / 236 runs failed over last 7 days	34.32% (81) 81 / 236 runs flaked over last 7 days

⚠️ Flakes

📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests -- future user Different Locations Tests can add single organizer address location without display location public option Retry 1 • Initial Attempt	0% (0) 0 / 231 runs failed over last 7 days	3.90% (9) 9 / 231 runs flaked over last 7 days
Event Types tests -- future user Different Locations Tests can select 'display on booking page' option when multiple organizer input type are present Retry 2 • Retry 1 • Initial Attempt	0.43% (1) 1 / 230 run failed over last 7 days	11.74% (27) 27 / 230 runs flaked over last 7 days

📄 apps/web/playwright/profile.e2e.ts • 2 Flakes

Top 1 Common Error Messages

`null`	2 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Update Profile Can update a users email (verification enabled) Retry 2 • Retry 1 • Initial Attempt	36.99% (91) 91 / 246 runs failed over last 7 days	35.37% (87) 87 / 246 runs flaked over last 7 days
Update Profile Can resend verification link if the secondary email is unverified Retry 2 • Retry 1 • Initial Attempt	11.69% (29) 29 / 248 runs failed over last 7 days	29.03% (72) 72 / 248 runs flaked over last 7 days

📄 apps/web/playwright/booking-pages.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
pro user -- future Time slots should be reserved when selected Retry 1 • Initial Attempt	0% (0) 0 / 216 runs failed over last 7 days	5.56% (12) 12 / 216 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/namespacing.e2e.ts • 4 Flakes

Top 1 Common Error Messages

`null`	4 Test Cases Affected

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Namespacing Different namespaces can have different init configs Retry 1 • Initial Attempt	0% (0) 0 / 221 runs failed over last 7 days	62.44% (138) 138 / 221 runs flaked over last 7 days
Namespacing Inline Embed Add inline embed using a namespace without reload Retry 1 • Initial Attempt	0.45% (1) 1 / 223 run failed over last 7 days	62.33% (139) 139 / 223 runs flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed using a namespace Retry 1 • Initial Attempt	0.45% (1) 1 / 223 run failed over last 7 days	62.33% (139) 139 / 223 runs flaked over last 7 days
Namespacing Inline Embed Double install Embed Snippet with inline embed without a namespace(i.e. default namespace) Retry 1 • Initial Attempt	0% (0) 0 / 223 runs failed over last 7 days	65.02% (145) 145 / 223 runs flaked over last 7 days

📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default Retry 1 • Initial Attempt	3.26% (7) 7 / 215 runs failed over last 7 days	18.60% (40) 40 / 215 runs flaked over last 7 days

📄 apps/web/playwright/managedBooking/advancedOptions.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Check advanced options in a managed team event type Check advanced options in a managed team event type without offer seats Retry 1 • Initial Attempt	0.45% (1) 1 / 223 run failed over last 7 days	48.43% (108) 108 / 223 runs flaked over last 7 days

View Detailed Build Results

… Domain cases

keithwillcode added consumer core area: core, team members only labels May 8, 2024

vercel bot deployed to Preview – ai May 8, 2024 08:06 View deployment

vercel bot deployed to Preview – api May 8, 2024 08:10 View deployment

vercel bot deployed to Preview – dev May 8, 2024 08:15 View deployment

dosubot bot added this to the v4.2 milestone May 15, 2024

github-actions bot added High priority Created by Linear-GitHub Sync organizations area: organizations, orgs 🐛 bug Something isn't working labels May 17, 2024

fix: Use origin as provided in HeadSeo. origin would be different for…

1512298

… Domain cases

hariombalhara force-pushed the fix-seo-origin branch from f33f0ea to 2d97f3e Compare May 17, 2024 04:47

vercel bot deployed to Preview – ai May 17, 2024 04:50 View deployment

vercel bot deployed to Preview – api May 17, 2024 04:59 View deployment

vercel bot deployed to Preview – dev May 17, 2024 05:10 View deployment

hariombalhara added 3 commits May 18, 2024 12:22

Add a test

efbf863

Merge remote-tracking branch 'origin/main' into fix-seo-origin

3bae506

add more test

a0fa3c8

hariombalhara force-pushed the fix-seo-origin branch from 2d97f3e to a0fa3c8 Compare May 20, 2024 08:57

vercel bot deployed to Preview – ai May 20, 2024 09:00 View deployment

vercel bot deployed to Preview – api May 20, 2024 09:04 View deployment

vercel bot deployed to Preview – dev May 20, 2024 09:11 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

hariombalhara commented May 8, 2024 •

edited

vercel bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

hariombalhara commented May 8, 2024

github-actions bot commented May 8, 2024 •

edited

linear bot commented May 8, 2024

deploysentinel bot commented May 8, 2024 •

edited

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

Are you sure you want to change the base?

fix: Use origin as provided in HeadSeo. origin would be different for Domain cases #14935

Conversation

hariombalhara commented May 8, 2024 • edited

What does this PR do?

Status

Screenshots for the branch

Type of change

How should this be tested?

Mandatory Tasks

Checklist

vercel bot commented May 8, 2024 • edited

github-actions bot commented May 8, 2024 • edited

hariombalhara commented May 8, 2024

github-actions bot commented May 8, 2024 • edited

📦 Next.js Bundle Analysis for @calcom/web

Five Pages Changed Size

linear bot commented May 8, 2024

deploysentinel bot commented May 8, 2024 • edited

Current Playwright Test Results Summary

❌ Failures

Test Case Results

Test Case Results

⚠️ Flakes

Top 1 Common Error Messages

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Top 1 Common Error Messages

Test Case Results

Test Case Results

Test Case Results

hariombalhara commented May 8, 2024 •

edited

vercel bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

github-actions bot commented May 8, 2024 •

edited

deploysentinel bot commented May 8, 2024 •

edited