Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions test workflow #257

Merged
merged 2 commits into from
Jan 25, 2023
Merged

GitHub Actions test workflow #257

merged 2 commits into from
Jan 25, 2023

Conversation

DimitarNestorov
Copy link
Contributor

Summary

yarn test was failing when running on main

Test plan

CI job passes

thymikee
thymikee approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I recall we disabled the incorrect hint lint and didn't update the test apparently

@thymikee thymikee merged commit 4c4c145 into callstack:main Jan 25, 2023
@thymikee
Copy link
Member

Thank you @DimitarNestorov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DimitarNestorov @thymikee