Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update vscode settings config of README.md #264

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

rezkiy37
Copy link
Member

@rezkiy37 rezkiy37 commented Jun 5, 2023

Summary

The issue (#263) is that there is a little bit deprecated suggestion for VSCode settings config. Once I've added @callstack/eslint-config I saw a warning (check a screenshot below).
Looks like there was an update where autoFix started to be a default value. No sense to set it explicitly anymore. So I've updated README.md.

Test plan

  1. Add @callstack/eslint-config to a project
  2. Add VSCode config to your .vscode/settings.json

Initial warning

Screenshot 2023-06-05 at 15 19 17

Fix

Screenshot 2023-06-05 at 15 19 01

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@thymikee thymikee merged commit e15ab1e into main Jun 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants