feat: Narrow react/no-multi-comp rule #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussed in callstack#50.
matthargett
changed the title
satya164
approved these changes
May 7, 2019
|
Let's hold off on this to see if eslint-plugin-react 's fix for this problem in 7.13.0 resolves the issue. Merged PR referenced in the CHangelog: |
|
@satya164 @thymikee It looks like 7.13.0 fixes the ignoreStateless property. I like the gentle nudging for developers to extract for better re-usability, so instead of turning it off I'm setting it as a warning. As we roll out this eslint update to a few dozen repos, I'll monitor closely to see if it needs to be completely disabled. can you merge and publish? |
matthargett
changed the title
thymikee
approved these changes
May 11, 2019
thymikee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Discussed in #50.
The current rule being enabled can be noisy for perfectly fine code. There's a way to partially disable it, but consensus in issue #50 was to disable the rule altogether.
Test plan
Resolved noise on an internal project.