Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure that linaria plugin to run first #343

Merged
merged 1 commit into from Mar 7, 2019
Merged

fix: ensure that linaria plugin to run first #343

merged 1 commit into from Mar 7, 2019

Conversation

satya164
Copy link
Member

@satya164 satya164 commented Mar 7, 2019 •
edited

fixes #333

@callstack-bot
Copy link

callstack-bot commented Mar 7, 2019 •
edited

Hey @satya164, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

@satya164 satya164 changed the title wip: force linaria plugin to run first fix: ensure that linaria plugin to run first Mar 7, 2019
@satya164 satya164 requested review from thymikee and zamotany and removed request for thymikee March 7, 2019 20:56
thymikee
thymikee approved these changes Mar 7, 2019
View reviewed changes
Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty hacky, isn't it? but what can you do in a plugin system without priority 🤷‍♂️

@satya164 satya164 merged commit 15986c8 into master Mar 7, 2019
@satya164 satya164 deleted the @satya164/plugin-order branch March 7, 2019 23:17
@matiasbuildops matiasbuildops mentioned this pull request Jan 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thymikee thymikee thymikee approved these changes

@zamotany zamotany zamotany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

linaria/babel throws error on nested object interpolations within css
4 participants
@satya164 @callstack-bot @thymikee @zamotany