Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dedent is a devDep of @linaria/shaker, not a prod dep #711

Merged
merged 1 commit into from Dec 8, 2020

Conversation

ChALkeR
Copy link
Contributor

@ChALkeR ChALkeR commented Nov 27, 2020

Motivation

Remove an unsed production dep.

Summary

Like in other packages, dedent is actually a dev dep.
@linaria/babel:

"devDependencies": {
"@types/cosmiconfig": "^5.0.3",
"@types/dedent": "^0.7.0",
"dedent": "^0.7.0",

@linaria/server:
"devDependencies": {
"@types/dedent": "^0.7.0",
"dedent": "^0.7.0",

Grep output:

$ grep -r dedent packages/shaker/
packages/shaker/package.json:    "@types/dedent": "^0.7.0",
packages/shaker/package.json:    "dedent": "^0.7.0"
packages/shaker/__tests__/shaker.test.ts:import dedent from 'dedent';
packages/shaker/__tests__/shaker.test.ts:        dedent`
packages/shaker/__tests__/shaker.test.ts:        dedent`
packages/shaker/__tests__/shaker.test.ts:        dedent`

Seems to be used only in tests.

Test plan

Regular tests should pass.
I also checked that this package still works when dedent module is removed from node_modules.

@callstack-bot
Copy link

Hey @ChALkeR, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants