Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(babel): rename @linaria/babel to @linaria/babel-preset (#704) #720

Merged
merged 2 commits into from Dec 8, 2020

Conversation

Anber
Copy link
Collaborator

@Anber Anber commented Dec 8, 2020

Motivation

Babel forces to use standardized names for plugins and presets.

Summary

@linaria/babel has been renamed @linaria/babel-preset, so that Babel will allow to use it without prefix module: in a list of presets. (#704)

Copy link
Member

@thymikee thymikee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is a breaking change, so worth bumping major version when releasing

@Anber
Copy link
Collaborator Author

Anber commented Dec 8, 2020

@thymikee it's BC if we compare it with the first beta. I think it's ok to break something between beta.0 and beta.1. The old linara/babel will continue to work, so it's not even BC between 2.0 and 3.0.

@thymikee
Copy link
Member

thymikee commented Dec 8, 2020

Okies

@callstack-bot
Copy link

Hey @Anber, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants