Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: loadOptions test regex #728

Merged
merged 1 commit into from Jan 12, 2021

Conversation

Nedgeva
Copy link
Contributor

@Nedgeva Nedgeva commented Jan 11, 2021

Motivation

Fixes #727

Summary

Changes test regex in loadOptions to match node_modules path on Win machines, not only nix.

Test plan

  1. create sample project with react, linaria and webpack
  2. make dummy react component wrapped into react's memo
  3. wrap abovementioned react component into linaria's styled
  4. run build in different envs (e.g. linux, macos, windows)
  5. build should finish with success

@Nedgeva Nedgeva changed the title fix: loadOptions text regex fix: loadOptions test regex Jan 11, 2021
@callstack-bot
Copy link

Hey @Nedgeva, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

@Anber Anber merged commit 34ca3e5 into callstack:master Jan 12, 2021
@Anber
Copy link
Collaborator

Anber commented Jan 12, 2021

Thank you @Nedgeva!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluator behaves differently on nix and win OS due to weak path matching
3 participants