Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow install scripts to run on Windows #752

Merged
merged 1 commit into from Apr 19, 2021
Merged

chore: allow install scripts to run on Windows #752

merged 1 commit into from Apr 19, 2021

Conversation

Jack-Works
Copy link
Contributor

Motivation

Allow developing on Windows

Summary

Add cross-env to execute scripts with environment variables.

Test plan

No test needed.

Other

The pre-commit hook failed:

FAIL __tests__/detect-core-js.test.js
  ● Ensures that package do not include core-js dependency after build

    expect(received).toContain(expected) // indexOf

    Expected substring: "Based on your code and targets, core-js polyfills were not added"
    Received string:    "Successfully compiled 5 files with Babel (701ms).
    "

      28 |   // run `DEBUG_CORE_JS=true yarn build:lib` to debug issues with introduced core-js dependency
      29 |   expect(result).not.toContain('Added following core-js polyfill');
    > 30 |   expect(result).toContain(
         |                  ^
      31 |     'Based on your code and targets, core-js polyfills were not added'
      32 |   );
      33 | }, 15000);

      at Object.<anonymous> (__tests__/detect-core-js.test.js:30:18)

But I think it doesn't caused by my changes.

Another bug related to the upstream dependencies of Windows compatibility:

chrismohr/lerna-to-typescript-project-references#2

@callstack-bot
Copy link

Hey @Jack-Works, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

@Anber Anber merged commit 071815d into callstack:master Apr 19, 2021
@Jack-Works Jack-Works deleted the env branch April 19, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants