Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have some packages that export both ESM and CommonJS modules using conditional package exports using the
import
andrequire
conditions, such as in this example. These work fine in our Webpack 5 apps, however if we try to use these imports in Linaria blocks with the Linaria Webpack loader, it blows up with the error:Summary
What's missing is that the Linaria webpack loaders do not pass down the appropriate
conditionNames
to the enhanced resolver. This PR adds therequire
condition name by default, and also introduces the ability to customing the loaderresolveOptions
.Test plan
@rmazzeo-godaddy put together this repo that reproduces the problem.
git clone git@github.com:rmazzeo-godaddy/linaria-conditionnames-missing.git cd linaria-conditionnames-missing npm ci npm run start