Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shaker): support string literals for addressing values in imported NS #815

Merged
merged 1 commit into from Aug 8, 2021

Conversation

Anber
Copy link
Collaborator

@Anber Anber commented Aug 8, 2021

Motivation

Shaker didn't properly work with constructions like:

const module = require('./module');
const value = module["value"]; // `value` here wasn't recognized as an imported value

Summary

This PR adds support of string literals in the imported values usages detector.

Test plan

One test was modified.

@Anber Anber merged commit 8adf43e into master Aug 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant