fix(webpack): add cacheProvider for Linaria v3 #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malash
commented
Dec 18, 2021
| .then((cacheInstance) => cacheInstance.set(this.resourcePath, cssText)) | ||
| .then(() => { | ||
| const request = `${outputFileName}!=!${outputCssLoader}?cacheProvider=${encodeURIComponent( | ||
| cacheProvider ?? '' |
There was a problem hiding this comment.
I also fixed this line in #890
malash
commented
Dec 18, 2021
| .then((cacheInstance) => cacheInstance.set(this.resourcePath, cssText)) | ||
| .then(() => { | ||
| const request = `${outputFileName}!=!${outputCssLoader}?cacheProvider=${encodeURIComponent( | ||
| cacheProvider ?? '' |
There was a problem hiding this comment.
I also fixed this line in #890
Anber
reviewed
Dec 19, 2021
Anber
approved these changes
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR add the same feature as #884 for Linaria v3.
Summary
See #884
Test plan
I tested this PR in malash/linaria-issue-881@ae8ecca with
cacheProvider: undefinedandcacheProvider: require.resolve("./linariaFileCache")and they work as expected.@Anber