feat(atomic): add support for at-rules, keyframes and pseudo classes #913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anber
approved these changes
Feb 6, 2022
Gitbook allowed us to use a community plan so we will migrate all documentation to it someday. If you wanna create documentation for |
|
Hi @jpnelson |
|
It was just excess |
|
Oh shoot, sorry I missed that! Thank you for figuring that out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for at-rules, keyframes and pseudo classes
Motivation
See #911
Summary
This changes the atomizer function to a different parsing method: visiting the parents of each declaration, and atomizing in a way that includes the parents.
Test plan
I tested the result on the website, and also added some unit tests.
I wonder if we need to expand the website to include more demos of some of these things? It could be useful to have a sort of proof of concept page