Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow renaming of css template literals #973

Merged
merged 1 commit into from May 21, 2022

Conversation

jpnelson
Copy link
Contributor

This allows us to have atomic css and non atomic css live in the same file. It does this by supporting renames of css imports, which exist for styled but don't actually exist for css today. Eg:

import { css as myCss } from '@linaria/core';

myCss`...`;

previously did not work, whereas now it will. It also allows renaming of the old API:

import { css as myCss } from 'linaria';

as well as having multiple renames coexist:

import { css as coreCss } from '@linaria/core';
import { css as atomicCss } from '@linaria/atomic';
import { styled as myStyled } from '@linaria/react';

A few other things to note regarding backwards compatibility:

  1. I changed the metadata for localName to be an object of local names for each API surface rather than a string. I don't think it should be a problem to change this format
  2. I changed the name of DetectStyledImportName to DetectLinariaImportName as it now detects all linaria API's. This is technically a breaking change in the API as it's renaming an export, but I think it's an ok thing to do on master while we're on v3 beta versions. It shouldn't be hard to migrate, but might be worth making a note of in the changelog.
  3. This might have an impact on feat(atomic): add support for atomic using styled API #966 , but it should be possible to add to this in a straightforward way to allow renaming of any other API's from '@linaria/atomic' too.

Test plan

Tested with snapshot tests

@Anber
Copy link
Collaborator

Anber commented May 21, 2022

I've already done it in another branch, but don't know when it will be stable enough for merging, so lets use your implementation for a while.

@Anber Anber merged commit 8f59a82 into callstack:master May 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants