fix(esbuild): fix broken source maps #991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silviogutierrez
commented
Jun 14, 2022
| @@ -93,18 +102,21 @@ export default function linaria({ | |||
| const slug = slugify(cssText); | |||
| const cssFilename = `${filename}_${slug}.linaria.css`; | |||
|
|
|||
| let contents = `import ${JSON.stringify(cssFilename)}; ${result.code}`; | |||
There was a problem hiding this comment.
I noticed everything needs to be in one line. Otherwise the maps will be off by 1 line.
I also couldn't figure out what the import statement here achieves. Without it, CSS still worked fine. But I left it there due to https://en.wikipedia.org/wiki/Wikipedia:Chesterton's_fence
There was a problem hiding this comment.
I have no idea about the import either :)
Anber
approved these changes
Jun 17, 2022
|
Thank you, @silviogutierrez! |
Anber
added a commit
that referenced
this pull request
Jun 17, 2022
This was referenced Jul 19, 2023
chore(deps): update dependency @linaria/webpack-loader to v4 - autoclosed
yuta4j1/docker-analyzer#39
Closed
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #898
Motivation
Summary
Test plan