Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v13] chore: remove deprecated stuff #1603

Merged
merged 4 commits into from May 6, 2024

Conversation

mdjastrzebski
Copy link
Member

Summary

Remove deprecated stuff:

  • *ByAccessibilityState queries
  • *ByAccessibilityValue queries
  • use modern flushMicroTasks instead of flushMicroTasksLegacy

Test plan

All checks should pass.

@mdjastrzebski mdjastrzebski requested review from MattAgn, AugustinLF, pierrezimmermannbam and thymikee and removed request for MattAgn and AugustinLF May 3, 2024 09:52
Copy link
Collaborator

@pierrezimmermannbam pierrezimmermannbam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice to have this cleaned, also excellent migration doc, well done!

@pierrezimmermannbam
Copy link
Collaborator

Should the target branch be something other than main though? I thought we'd work on a separate branch for react 19 or do we still want to remove those on main?

@mdjastrzebski mdjastrzebski changed the base branch from main to v13 May 3, 2024 16:00
@mdjastrzebski
Copy link
Member Author

@pierrezimmermannbam you're right, it should be v13. Fixed it.

@mdjastrzebski mdjastrzebski merged this pull request into v13 May 6, 2024
5 checks passed
@mdjastrzebski mdjastrzebski deleted the chore/v13-remove-deprecated-stuff branch May 6, 2024 19:29
mdjastrzebski added a commit that referenced this pull request May 6, 2024
* chore: remove flush microtask legacy

* chore: remove deprecated *ByAccessibilityState, *ByAccessibilityValue queries

* chore: add docs

* docs: add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants