Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove stale examples #1608

Merged
merged 1 commit into from May 7, 2024
Merged

Conversation

mdjastrzebski
Copy link
Member

Summary

Remove stale examples for Redux
Remove stale docs for Redux and React Navigation

Test plan

@friederbluemle
Copy link
Contributor

I think the Redux examples could still be useful, even if "stale". Is there a chance to get the outdated examples updated instead of removed altogether?

@mdjastrzebski
Copy link
Member Author

I definitely would like to have a proper Redux example (as well as examples for other state management solutions). However, the current "example" goes against our recommended testing best practices 🤷‍♂️

@friederbluemle would you be interested in contributing a small Redux setup example for RNTL that could be added to this repo? I offer my guidance and code review.

@mdjastrzebski mdjastrzebski merged commit 1b732d6 into main May 7, 2024
5 checks passed
@mdjastrzebski mdjastrzebski deleted the chore/remove-stale-examples branch May 7, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants