Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip husky install #654

Merged
merged 4 commits into from May 22, 2023
Merged

skip husky install #654

merged 4 commits into from May 22, 2023

Conversation

nonoakij
Copy link
Contributor

@nonoakij nonoakij commented May 19, 2023

Summary

Checklist

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

⚠️ No Changeset found

Latest commit: 8426b82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nonoakij nonoakij self-assigned this May 22, 2023
@ejithon
Copy link
Contributor

ejithon commented May 22, 2023

As mentioned below, it seems to changed the life cycle scripts prepare from postinstall. https://github.com/typicode/husky#usage

@nonoakij
Copy link
Contributor Author

As mentioned below, it seems to changed the life cycle scripts changed to prepare from postinstall. https://github.com/typicode/husky#usage

It seems that changes have been made in typicode/husky#890 .
I will look into the reason behind them.

@nonoakij
Copy link
Contributor Author

typicode/husky#884

@nonoakij nonoakij requested a review from ejithon May 22, 2023 04:46
Copy link
Contributor

@ejithon ejithon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@nonoakij nonoakij merged commit 10a8115 into develop May 22, 2023
@nonoakij nonoakij deleted the skip-huskey-install branch May 22, 2023 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants