Update to Electron 7

[nikku]

Works on

• Linux
• MacOS
• Windows

---

Closes #1448

[nikku]

This was straight forward (and works on Linux).

[nikku]

Needs double check on MacOS and Windows.

[oguzeroglu]

I cannot export images on Mac. Could you verify it works on Linux?

[oguzeroglu]

I think there's a change in return values of dialogs with this electron version. Image export/Save file as etc. kinda stuff is not working. I tried to debug the image export thing a bit. It seems like awaiting showSaveFileDialog in App.js is not working now.

[nikku]

I can reproduce it on Linux, too. Will look into it and report back on my findings.

[nikku]

Fixed by updating our dialog. The Electron Dialog is promisified now.

[oguzeroglu]

Works on Mac 👍

[nikku]

@philippfromme Could you give this one a look and verify it works on Windows ©️ ®️ 💥, too?

[philippfromme]

Doesn't work on Windows. Built executables error with the following message:

In development mode SVGs cannot be loaded which probably is an issue with the Karma configuration.

[nikku]

What are your exact steps to reproduce the errors?

[philippfromme]

@nikku

• npm run build:distro and running Camunda Modeler leads to Not allowed to load local resource
• npm run dev leads to Failed to execute 'createElement' on 'Document': The tag name provided ('static/media/Play.f79fe6ae.svg') is not a valid name. error in the log

[nikku]

Did you try a clean install npm install && npm run all, too?

[philippfromme]

I had to update nyc to successfully run npm run all on Windows (see istanbuljs/nyc#1205). Of cource npm run build:distro doesn't build the client so that was the issue.

The issue regarding SVGs in development mode is not related to the Electron update.

[nikku]

Thanks for clarifying. ❤️