ci: always cache maven dependencies #12424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results1 054 files ± 0 1 054 suites ±0 1h 55m 34s ⏱️ - 10m 2s Results for commit b42252d. ± Comparison against base commit fd19810. This pull request removes 664 and adds 585 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
oleschoenburg
force-pushed
the
os-always-cache-maven
branch
4 times, most recently
from
f1c990b
to
ec81138
Compare
|
@oleschoenburg what's missing for this one? recently I noticed docker checks and some smoke jobs seem to be the ones taking the most time now, I guess caching could help to reduce their duration. Shall we rebase and evaluate the effect with a couple of runs? |
|
@megglos Nothing really. I wanted to try out a dedicated caching job that runs on main so that PRs only restore a cache but really this can be a different PR if we even want to do this. I'll rebase and start a couple of runs. Thanks for the reminder 👍 |
oleschoenburg
force-pushed
the
os-always-cache-maven
branch
from
ec81138
to
7fa26fc
Compare
oleschoenburg
force-pushed
the
os-always-cache-maven
branch
from
1f016d6
to
792cc54
Compare
|
😄 |
npepinpe
approved these changes
May 9, 2023
| -D maven.artifact.threads=32 | ||
| EOF | ||
| - name: Cache local Maven repository | ||
| if: inputs.java == 'true' && startsWith(runner.name, 'actions-runner-') |
There was a problem hiding this comment.
🤡 Shame we can't access the labels here =/
npepinpe
added
backport stable/8.0
backport stable/8.2
|
bors r+ |
|
bors r- |
|
Canceled. |
This creates `.mvn/maven.config` with config that we want to use for all maven invocations in CI. Otherwise, it's easy to make changes where we would suddenly run maven with different config that is either incompatible or not as reliable.
This ensures that we don't cache locally installed artifacts or snapshot artifacts from our dependencies.
oleschoenburg
force-pushed
the
os-always-cache-maven
branch
from
81df9ce
to
91983b0
Compare
|
bors merge |
|
Build succeeded: |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.0
git worktree add -d .worktree/backport-12424-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-12424-to-stable/8.0
git checkout -b backport-12424-to-stable/8.0
ancref=$(git merge-base dc94b82a91a41061fdab55d7cbfbd3d901d7d3b2 91983b025667cd72aba97087ce43ba571f10aa71)
git cherry-pick -x $ancref..91983b025667cd72aba97087ce43ba571f10aa71 |
|
Backport failed for Please cherry-pick the changes locally. git fetch origin stable/8.1
git worktree add -d .worktree/backport-12424-to-stable/8.1 origin/stable/8.1
cd .worktree/backport-12424-to-stable/8.1
git checkout -b backport-12424-to-stable/8.1
ancref=$(git merge-base dc94b82a91a41061fdab55d7cbfbd3d901d7d3b2 91983b025667cd72aba97087ce43ba571f10aa71)
git cherry-pick -x $ancref..91983b025667cd72aba97087ce43ba571f10aa71 |
|
Successfully created backport PR for |
oleschoenburg
added
the
version:8.2.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we use and cache the local maven repository. This allows us to always build Zeebe in parallel and makes caching a more reliable.
To do this, we are using a new repository layout that supports concurrent builds and that splits release and snapshot artifacts. Splitting is very useful for us because we can now ensure that we only cache released artifacts and that locally built snapshot artifacts are not reused because that would be a correctness hazard.
Caching of maven dependencies is now always enabled but we split the caches between GH- and self-hosted (because they are not compatible with each other) and we use more cache modifiers to ensure that jobs that built only part of Zeebe don't create caches that are too small, i.e. contain only a few of Zeebe's dependencies.
Latest test run is here: https://github.com/camunda/zeebe/actions/runs/4916223809