refactor(snapshots): Replace Stream.toList and the for each cycle to Stream.forEachOrdered

[aivinog1]

Description

I replaced the collection with a list and the for each cycle to the Stream.forEactOrdered call. It should reduce memory footprint and possibly improve latency, especially on a large number of snapshot files.

Related issues

closes #12575

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

• The changes are backwards compatibility with previous versions
• If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/1.3) to the PR, in case that fails you need to create backports manually.

Testing:

• There are unit/integration tests that verify all acceptance criterias of the issue
• New tests are written to ensure backwards compatibility with further versions
• The behavior is tested manually
• The change has been verified by a QA run
• The impact of the changes is verified by a benchmark

Documentation:

• The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
• If the PR changes how BPMN processes are validated (e.g. support new BPMN element) then the Camunda modeling team should be informed to adjust the BPMN linting.

Other teams:
If the change impacts another team an issue has been created for this team, explaining what they need to do to support this change.

• Operate
• Tasklist
• Web Modeler
• Desktop Modeler
• Optimize

Please refer to our review guidelines.

[aivinog1]

Hello, reviewer!
First of all, this should be benchmarked with a large number of snapshot files, so that we could see the difference in the memory and snapshot creation latency.
Then, it should be nice to backport this in the 8.0, 8.1, and 8.2 as well.

[deepthidevaki]

🚀 Thanks @aivinog1 for your contribution.

Since this is reasonable change irrespective of performance improvement, I'm merging this without running a benchmark. You would see a difference only with large number of snapshot files anyway.

bors r+

[zeebe-bors-camunda]

Build failed:

• Test summary

[deepthidevaki]

Smoke test failed.

bors retry

[zeebe-bors-camunda]

Build succeeded:

• Test summary

[aivinog1]

Thanks @deepthidevaki 🎉
Could you approve the backport workflow, please? https://github.com/camunda/zeebe/actions/runs/4880268131
It will not create backport PRs without approval :(

[deepthidevaki]

@aivinog1 backport workflow is running. Please assign it to me when the backport PRs are created.

[aivinog1]

@aivinog1 backport workflow is running. Please assign it to me when the backport PRs are created.

@deepthidevaki It failed (I think because I drop my branch, but I just restored it now), could you restart the workflow, please? 🙂 Or check out what went wrong.

[deepthidevaki]

Let's try again.

/backport

[backport-action]

Backport failed for stable/8.0, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git fetch origin stable/8.0
git worktree add -d .worktree/backport-12576-to-stable/8.0 origin/stable/8.0
cd .worktree/backport-12576-to-stable/8.0
git checkout -b backport-12576-to-stable/8.0
ancref=$(git merge-base 02d1df8ac1b6f5484f1e9d4c1f19c8a5712176b1 499036719908a9487853a727c54e04c637119498)
git cherry-pick -x $ancref..499036719908a9487853a727c54e04c637119498

[backport-action]

Successfully created backport PR for stable/8.1:

• [Backport stable/8.1] refactor(snapshots): Replace Stream.toList and the for each cycle to Stream.forEachOrdered #12665

[backport-action]

Successfully created backport PR for stable/8.2:

• [Backport stable/8.2] refactor(snapshots): Replace Stream.toList and the for each cycle to Stream.forEachOrdered #12666