-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ContentDownloader Tool #1006
base: dev
Are you sure you want to change the base?
Conversation
src/experimental/tools/ContentDownloader/api/downloader/downloadManager.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a shallow first glance over this branch as we might want to finally merge it soon.
I just scrolled over if for now to look principally at interactions with the core of the RxPlayer
src/experimental/tools/ContentDownloader/api/downloader/segment.ts
Outdated
Show resolved
Hide resolved
src/experimental/tools/ContentDownloader/api/downloader/segment.ts
Outdated
Show resolved
Hide resolved
src/experimental/tools/ContentDownloader/api/downloader/initSegment.ts
Outdated
Show resolved
Hide resolved
b313d32
to
d5c0748
Compare
Hey folks, thanks for your awesome work on RX-Player. ping @peaBerberian |
Hi @et84121, and thanks! It is still a feature that is wanted in the long term, but its priority was lowered at Canal+. We are however going back on it once in a while to be sure this PR does not go too stale. Anyway, if you want to work on it, you're very welcome to do so. The global idea is too use What PaulRosset has done here was actually working at the time for most contents, but it had some rough edge. If you don't want and/or don't have time to implement the whole feature, you could do something simpler on your side that just handle the contents you encounter. Here, you would just have to output a format compatible to the RxPlayer's "local" transport. |
Hi @PaulRosset, Thank you for your thorough response. I am working on rebasing this branch, but I am not sure I will complete it finally. In addition, I have a few questions I want to ask.
Thank you again for your detailed response. |
0bb9931
to
8ae7edf
Compare
b67e176
to
f45bcce
Compare
3668ba7
to
b0968f0
Compare
675d062
to
64496c9
Compare
044f145
to
70689ce
Compare
7cb8d1e
to
0ca048d
Compare
0fb075b
to
efc5206
Compare
b0b4607
to
01591ca
Compare
efc5206
to
fe90a7f
Compare
1d66ba6
to
13fbfcc
Compare
fe90a7f
to
41ba064
Compare
cb2d365
to
44edcfd
Compare
41ba064
to
817516b
Compare
90fbc13
to
cd9ff08
Compare
817516b
to
db53005
Compare
db53005
to
99df0b5
Compare
2223d20
to
1de6ca5
Compare
99df0b5
to
27d1fdc
Compare
27d1fdc
to
bff7bb8
Compare
2e58dd6
to
cc6a502
Compare
bff7bb8
to
0710d4e
Compare
PS: This is a new PR from #548.
What's included?
Review