Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DRM): keys missing in the license marked as decipherable #1429

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

Florent-Bouisset
Copy link
Collaborator

@Florent-Bouisset Florent-Bouisset commented Apr 11, 2024

Previously, even if certain keys were missing from a license, the representation was still marked as decipherable. This commit change this behavior to require explicit inclusion of keys in the license for the representation to be considered decipherable.

Relates to #1427

Previously, even if certain keys were missing from a license,
the representation was still marked as decipherable.
This commit change this behavior to require explicit inclusion of keys
in the license for the representation to be considered decipherable.
@peaBerberian
Copy link
Collaborator

peaBerberian commented Apr 23, 2024

So as we said (I'm just writing it here so we don't forget) maybe the best way would be to notice after the onKeyUpdate callback is called in the ContentDecryptor that the key id we asked for is not in there, and in that case blacklist that key id / init data.

We could potentially do that by linking a KeySessionRecord to the initial key id + init data, to check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants