Fix memory tests on Chrome 124 #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
force-pushed
the
fix/memory-tests
branch
4 times, most recently
from
69dca56
to
3f5a22e
Compare
Our memory tests (which checks for memory leaks) are failing since Chrome 124. It seems that the issue is not memory leaks on our part but changes in the way Chrome performs its garbage collection, especially after the `gc` global function (it exposes it only if the `--js-flags="--expose-gc"` chrome flag is used when running) call. Awaiting several seconds after that call seems to improve measures by a lot (tens of MB being collected), though not every tests seems to pass yet, so that may not be the only change we'll need to do.
peaBerberian
force-pushed
the
fix/memory-tests
branch
from
3f5a22e
to
4420c06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our memory tests (which check for memory leaks) are failing since Chrome 124.
It seems that the issue is not memory leaks on our part but changes in the way Chrome performs its garbage collection, especially after the
gcglobal function (it exposes it only if the--js-flags="--expose-gc"chrome flag is used when running) is called to manually trigger it.Awaiting several seconds after that call seems to improve measures by a lot (tens of MB being collected), though not every tests seems to pass yet, so that may not be the only change we'll need to do.