Update TypeScript to v3.9.3 and other dependencies #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peaBerberian
force-pushed
the
misc/dependencies-typescriptv3.9.2
branch
from
c78f105
to
237a322
Compare
grenault73
approved these changes
Jun 3, 2020
|
Travis and appveyor fail with eslint but it works on my machine(TM). Weird as the problem seems to be in one of our dependencies (eslint) which is also on my computer under the same form. |
|
From eslint release notes:
Travis has Node v8.17.0 So that must be it :'( I'll see if we can do something about it in travis/appveyor |
peaBerberian
force-pushed
the
misc/dependencies-typescriptv3.9.2
branch
from
89760c4
to
cef9229
Compare
|
Ok that's better. |
Under the previous code, we aborted any Manifest refresh operation if we did not find an URL associated to the Manifest. This might seem logical at first, but we may also have a custom `manifestLoader` defined through the corresponding loadVideo option, which make the presence of the URL completely optional. The real use cases are for when the Manifest is available locally, most of all under the `local` transport to be able to play content offline. In such contents, we never have an URL, only a custo `manifestLoader` which will retrieve the stored contents directly from memory or whatever browser storage API is available (IndexedDB, custom APIs...).
…Track replacement type TypeScript v3.9.x seems to have removed its type definitions for those DOM APIs (video tracks and audio tracks we can find on an HTMLMediaElement). The reason why are not clear but judging by the problematic commit (microsoft/TypeScript@065a996#diff-46fd87925e4552c166ec188712741c3f) - meaning of LKG being "last known good". My guess would be that it is automatically generated from a source which does not have those APIs (why we had them before is more of a mystery but I guess that's what this LKG thing was about). What I did in this commit is to creates four new types: - ICompatAudioTrackList - ICompatVideoTrackList - ICompatAudioTrack - ICompatVideoTrack Which are respectively the implementation of an AudioTrackList, VideoTrackList, AudioTrack and VideoTrack as they are defined in the web-idl of the corresponding APIs in the whatwg spec (https://html.spec.whatwg.org/multipage/media.html#audiotracklist-and-videotracklist-objects). I chose to name those ICompatThing and not directly extending Thing because I find it allows to better see which types are "native" TypeScript ones and which have been actually extended because they missed some browser APIs. As TypeScript could evolve to add those APIs, we could need to remove those. So making them stand out from the rest is and advantage to me.
peaBerberian
force-pushed
the
misc/dependencies-typescriptv3.9.2
branch
from
cef9229
to
5bfb982
Compare
|
I want to assassinate appveyor |
peaBerberian
force-pushed
the
misc/dependencies-typescriptv3.9.2
branch
from
5bfb982
to
082cef5
Compare
|
Hm, well I will see what I can do for those tests as it at least 4 failure in a row now. What's re-assuring is that it's always the same test, which is a performance-based one (setPlaybackRate). This can be due to poor decoder performance - as well as poor JS performance. |
Appveyor seems to have trouble with this one, and it seems to be related to performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript v3.9.x seems to bring a lot of change to browser type definitions related to AudioTrack, VideoTrack and TextTrack.
Every problematic types are now only contained in the MediaElementTrackChoiceManager (where such types are used).
We should fix those and ensure that the other dependencies don't bring anything too fishy (by comparing builds before and after?).