Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run scripts instead of inserting into head #172

Merged
merged 3 commits into from Apr 4, 2024
Merged

Run scripts instead of inserting into head #172

merged 3 commits into from Apr 4, 2024

Conversation

samhotep
Copy link
Member

Done

  • Run scripts directly, rather than inserting into the page header

QA

  • Clone the repo
  • Build and run the demo
$ yarn build
$ yarn serve
  • Before accepting any preferences, output the value of window.dataLayer in the console
  • It should contain {"consent", "default", ...}
  • After accepting any preferences, output the value of window.dataLayer in the console
  • It should contain {"consent", "update", ...}

@samhotep samhotep self-assigned this Mar 28, 2024
petesfrench
petesfrench approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@petesfrench petesfrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samhotep samhotep merged commit bdf7818 into main Apr 4, 2024
4 checks passed
@samhotep samhotep deleted the run-consent-script-by-default branch April 4, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petesfrench petesfrench petesfrench approved these changes

Assignees

@samhotep samhotep

Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samhotep @petesfrench