Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add tox #295

Merged
merged 2 commits into from
Jun 15, 2023
Merged

ci: add tox #295

merged 2 commits into from
Jun 15, 2023

Conversation

mr-cal
Copy link
Collaborator

@mr-cal mr-cal commented Jun 8, 2023 •
edited

  • Have you signed the CLA?

Enable tox!

(CRAFT-1726)

@mr-cal mr-cal marked this pull request as draft June 8, 2023 17:26
@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (main@511996d). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #295   +/-   ##
=======================================
  Coverage        ?   96.69%           
=======================================
  Files           ?       36           
  Lines           ?     2237           
  Branches        ?      305           
=======================================
  Hits            ?     2163           
  Misses          ?       47           
  Partials        ?       27

@mr-cal mr-cal mentioned this pull request Jun 8, 2023
Closed
13 tasks
@mr-cal mr-cal force-pushed the tox branch 3 times, most recently from 26f8505 to 131ea46 Compare June 8, 2023 19:05
@mr-cal mr-cal mentioned this pull request Jun 8, 2023
Merged
1 task
@mr-cal mr-cal force-pushed the tox branch 5 times, most recently from dcae692 to f2c110d Compare June 14, 2023 13:05
@mr-cal mr-cal marked this pull request as ready for review June 14, 2023 13:06
@mr-cal mr-cal force-pushed the tox branch 4 times, most recently from 2d940d8 to e8f6fc2 Compare June 14, 2023 18:35
@mr-cal mr-cal changed the title (draft) ci: add tox ci: add tox Jun 14, 2023
@mr-cal mr-cal requested review from lengau and tigarmo June 14, 2023 22:24
@mr-cal mr-cal force-pushed the tox branch 3 times, most recently from f182c94 to 90ba3da Compare June 15, 2023 02:24
@mr-cal
ci: add tox
e236924 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
lengau
lengau approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@lengau lengau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the default environments — tox-gh is your choice but also comes with the advantage of cleaning up some of the CI messiness.

tox.ini Outdated Show resolved Hide resolved
tox.ini Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
lengau
lengau reviewed Jun 15, 2023
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
@mr-cal mr-cal force-pushed the tox branch 3 times, most recently from 62df576 to 364f7ee Compare June 15, 2023 17:49
@mr-cal mr-cal force-pushed the tox branch 2 times, most recently from 502df5b to 7cf6548 Compare June 15, 2023 18:49
@mr-cal
feedback from PR
405edfb 
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal merged commit 9ebe593 into main Jun 15, 2023
15 checks passed
@mr-cal mr-cal deleted the tox branch June 15, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lengau lengau lengau approved these changes

@tigarmo tigarmo Awaiting requested review from tigarmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mr-cal @lengau