Skip to content

Commit

Permalink
patch(integration_test_charm.yaml): Update secret docs to avoid redac…
Browse files Browse the repository at this point in the history
…ting `{` and `}` from logs (#166)

Tested on canonical/opensearch-operator#235

If `{` is on its own line, it gets redacted from logs
By moving `{` to a line with one of the secrets, `{` no longer gets
redacted from logs
  • Loading branch information
carlcsaposs-canonical committed Apr 16, 2024
1 parent 52f3d97 commit f86cfdf
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/integration_test_charm.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ jobs:
with:
# ...
secrets:
# GitHub appears to redact each line of a multi-line secret
# Avoid putting `{` or `}` on a line by itself so that it doesn't get redacted in logs
integration-test: |
{
"AWS_ACCESS_KEY_ID": "${{ secrets.AWS_ACCESS_KEY_ID }}",
"AWS_SECRET_ACCESS_KEY": "${{ secrets.AWS_SECRET_ACCESS_KEY }}",
}
{ "AWS_ACCESS_KEY_ID": "${{ secrets.AWS_ACCESS_KEY_ID }}",
"AWS_SECRET_ACCESS_KEY": "${{ secrets.AWS_SECRET_ACCESS_KEY }}", }
```

Python code to verify the string format:
Expand Down

0 comments on commit f86cfdf

Please sign in to comment.