Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable sentry integration for react router history #1424

Open
squidsoup opened this issue Jul 28, 2020 · 3 comments
Open

Enable sentry integration for react router history #1424

squidsoup opened this issue Jul 28, 2020 · 3 comments

Comments

@squidsoup
Copy link
Contributor

See: getsentry/sentry-javascript#2759

@squidsoup squidsoup changed the title Enable sentry intergration for react router history Enable sentry integration for react router history Jul 29, 2020
@huwshimi
Copy link
Contributor

This is the integration guide:
https://docs.sentry.io/platforms/javascript/guides/react/integrations/react-router/

Looks like they also have an integration with redux:
https://docs.sentry.io/platforms/javascript/guides/react/integrations/redux/

Our problem is that the integrations need to be set up earlier in the setup (currently we do the init in App.js), but we need to first check if analytics is enabled over the API.

Maybe we could use the beforeSend function to check: https://docs.sentry.io/platforms/javascript/guides/react/configuration/filtering/#using-before-send

@huwshimi huwshimi added MAAS and removed MAAS labels May 11, 2021
@petermakowski
Copy link
Collaborator

petermakowski commented May 11, 2022

It seems that these integrations may require Performance Monitoring to be enabled for them to work correctly.

Performance Monitoring requires upgrading sentry from our 9.1.2 version - we're using the latest stable snap https://snapcraft.io/sentry).

There may be some workarounds but not sure it makes sense investing in custom solutions that will become obsolete as soon as we upgrade.


Related: [Canonical IS Portal | Sentry upgrade request for Performance Monitoring]

@petermakowski
Copy link
Collaborator

blocked by #3932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants