Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new Percy CLI for Storybook #673

Merged
merged 1 commit into from
Dec 6, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
command: |
sudo apt-get update
sudo apt-get -y upgrade
sudo apt-get -yq install gconf-service libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxss1 libxtst6 libappindicator1 libnss3 libasound2 libatk1.0-0 libc6 ca-certificates fonts-liberation lsb-release xdg-utils wget
sudo apt-get -yq install gconf-service libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libcairo2 libcups2 libdbus-1-3 libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 libxdamage1 libxss1 libxtst6 libappindicator1 libnss3 libasound2 libatk1.0-0 libc6 ca-certificates fonts-liberation lsb-release xdg-utils wget libgbm-dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libgbm-dev added as mentioned in puppeteer issue comment

# Download and cache dependencies
- restore_cache:
keys:
Expand Down
4 changes: 4 additions & 0 deletions .percy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
version: 2
snapshot:
widths: [1280]
enable-javascript: true
5 changes: 3 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@
"@babel/cli": "7.16.0",
"@babel/eslint-parser": "7.16.3",
"@babel/preset-typescript": "7.16.0",
"@percy/storybook": "3.3.1",
"@percy/cli": "1.0.0-beta.71",
"@percy/storybook": "4.1.0",
"@storybook/addon-a11y": "6.4.8",
"@storybook/addon-controls": "6.4.8",
"@storybook/addon-docs": "6.4.8",
Expand Down Expand Up @@ -116,7 +117,7 @@
"lint-style": "stylelint src/**/*.scss",
"lint-package-json": "npmPkgJsonLint .",
"lint": "yarn lint-package-json && yarn lint-js && yarn lint-style",
"percy": "yarn build-docs && percy-storybook --build_dir=docs --widths=1280",
"percy": "yarn build-docs && percy storybook ./docs",
"prepublishOnly": "yarn clean && yarn install && yarn build",
"serve": "yarn docs",
"start": "yarn docs",
Expand Down