Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discourse url to engage page #13298

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

carkod
Copy link
Contributor

@carkod carkod commented Oct 27, 2023

Done

QA

Issue / Card

Fixes WD-11357

@webteam-app
Copy link

Demo starting at https://ubuntu-com-13298.demos.haus

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.43%. Comparing base (3a7954a) to head (45eea84).
Report is 6 commits behind head on main.

Current head 45eea84 differs from pull request most recent head f080944

Please upload reports for the commit f080944 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13298      +/-   ##
==========================================
+ Coverage   74.12%   74.43%   +0.30%     
==========================================
  Files         107      107              
  Lines        2864     2840      -24     
  Branches      957      948       -9     
==========================================
- Hits         2123     2114       -9     
+ Misses        715      702      -13     
+ Partials       26       24       -2     

see 14 files with indirect coverage changes

@carkod carkod force-pushed the add-discourse-url-to-engage-page branch 2 times, most recently from b9439f8 to 45eea84 Compare October 27, 2023 17:39
@akbarkz
Copy link
Contributor

akbarkz commented Nov 4, 2023

@carkod What's the corresponding Jira ticket for this?

Copy link
Contributor

@britneywwc britneywwc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This should make it easier to find the origin of discourse pages
@carkod carkod force-pushed the add-discourse-url-to-engage-page branch from 45eea84 to f080944 Compare June 7, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants