Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show plus sign when maximum tracking is reached #13810

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

britneywwc
Copy link
Contributor

@britneywwc britneywwc commented Apr 26, 2024

Done

  • Blocked by missing attribute from ua-contracts API
  • Hardcoded maxTracking value for now to show "+" in front of active machines number

QA

  • Check out this feature branch
  • Go to /pro/dashboard
  • See "+" in front of active machines number

Issue / Card

Fixes WD-10492

Screenshots

[If relevant, please include a screenshot.]

Help

QA steps - Commit guidelines

@webteam-app
Copy link

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.12%. Comparing base (e3eeefa) to head (04519a1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13810   +/-   ##
=======================================
  Coverage   74.11%   74.12%           
=======================================
  Files         107      107           
  Lines        2863     2864    +1     
  Branches      956      957    +1     
=======================================
+ Hits         2122     2123    +1     
  Misses        715      715           
  Partials       26       26           
Files Coverage Δ
...scriptionDetails/DetailsContent/DetailsContent.tsx 92.85% <100.00%> (+0.17%) ⬆️
static/js/src/advantage/tests/factories/api.ts 100.00% <ø> (ø)

@abhigyanghosh30 abhigyanghosh30 self-requested a review May 30, 2024 14:14
Copy link
Contributor

@abhigyanghosh30 abhigyanghosh30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhigyanghosh30 abhigyanghosh30 merged commit a215d81 into canonical:main Jun 4, 2024
16 checks passed
@britneywwc britneywwc deleted the pro-max-machines branch June 6, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants