Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Milk-V tab #13861

Merged
merged 1 commit into from
May 27, 2024
Merged

Add Milk-V tab #13861

merged 1 commit into from
May 27, 2024

Conversation

carkod
Copy link
Contributor

@carkod carkod commented May 14, 2024

To be deployed 27th of May

Done

  • Add new tab to the navigation
  • Add content to the tab

QA

Issue / Card

Fixes https://warthogs.atlassian.net/browse/WD-10765

@webteam-app
Copy link

@akbarkz
Copy link
Contributor

akbarkz commented May 14, 2024

@carkod Can you add a link to the page in the description please? And then share it with Felicia.

@carkod
Copy link
Contributor Author

carkod commented May 14, 2024

@carkod Can you add a link to the page in the description please? And then share it with Felicia.

She is already reviewing. I'll complete the rest once I get her +1

@carkod carkod force-pushed the milk-v-mars-wd-10765 branch 3 times, most recently from 10c51b6 to a434f4b Compare May 15, 2024 14:47
@carkod
Copy link
Contributor Author

carkod commented May 16, 2024

Felicia approved in the ticket

Copy link
Member

@samhotep samhotep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carkod carkod assigned mtruj013 and unassigned samhotep May 23, 2024
@mtruj013 mtruj013 merged commit a24b3e7 into canonical:main May 27, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants