Merge pull request #3283 from lyubomir-popov/872-button-alt

Accessibility fix: Remove alt attribs from all buttons
canonical · Sep 18, 2020 · 05e55a2 · 05e55a2
2 parents 726a2e0 + 4842e11
commit 05e55a2
Show file tree

Hide file tree

Showing 9 changed files with 22 additions and 22 deletions.
diff --git a/templates/_layouts/_header.html b/templates/_layouts/_header.html
@@ -26,8 +26,8 @@
       {% if path.startswith('/docs') %}
       <form class="p-search-box" action="/docs/search">
         <input type="search" id="search-docs" class="p-search-box__input" name="q" {% if query %}value="{{ query }}"{% endif %} placeholder="Search the docs" title="Search the documentation" required />
-        <button type="reset" id="search-docs-reset" class="p-search-box__reset u-no-margin--right" alt="reset"><i class="p-icon--close"></i></button>
-        <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search"></i></button>
+        <button type="reset" id="search-docs-reset" class="p-search-box__reset u-no-margin--right"><i class="p-icon--close"></i></button>
+        <button type="submit" class="p-search-box__button"><i class="p-icon--search"></i></button>
       </form>
       {% endif %}
     </nav>

diff --git a/templates/docs/examples/layouts/documentation.html b/templates/docs/examples/layouts/documentation.html
@@ -41,8 +41,8 @@
   <div class="row">
     <form class="p-search-box u-no-margin--bottom" action="#">
       <input type="search" class="p-search-box__input" name="q" placeholder="Search documentation" required="" />
-      <button type="reset" class="p-search-box__reset" alt="reset"><i class="p-icon--close">Close</i></button>
-      <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search">Search</i></button>
+      <button type="reset" class="p-search-box__reset"><i class="p-icon--close">Close</i></button>
+      <button type="submit" class="p-search-box__button"><i class="p-icon--search">Search</i></button>
     </form>
   </div>
 </section>

diff --git a/templates/docs/examples/patterns/search-box/default-dark.html b/templates/docs/examples/patterns/search-box/default-dark.html
@@ -6,12 +6,12 @@
 {% block content %}
 <form class="p-search-box is-dark">
   <input type="search" class="p-search-box__input" name="search" placeholder="Search" required>
-  <button type="reset" class="p-search-box__reset" alt="reset"><i class="p-icon--close"></i></button>
-  <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search"></i></button>
+  <button type="reset" class="p-search-box__reset"><i class="p-icon--close"></i></button>
+  <button type="submit" class="p-search-box__button"><i class="p-icon--search"></i></button>
 </form>
 <form class="p-search-box is-dark">
   <input type="search" class="p-search-box__input" name="search" placeholder="Search" required disabled>
-  <button type="reset" class="p-search-box__reset" alt="reset" disabled><i class="p-icon--close"></i></button>
-  <button type="submit" class="p-search-box__button" alt="search" disabled><i class="p-icon--search"></i></button>
+  <button type="reset" class="p-search-box__reset" disabled><i class="p-icon--close"></i></button>
+  <button type="submit" class="p-search-box__button" disabled><i class="p-icon--search"></i></button>
 </form>
 {% endblock %}
diff --git a/templates/docs/examples/patterns/search-box/default.html b/templates/docs/examples/patterns/search-box/default.html
@@ -6,12 +6,12 @@
 {% block content %}
 <form class="p-search-box">
   <input type="search" class="p-search-box__input" name="search" placeholder="Search" required>
-  <button type="reset" class="p-search-box__reset" alt="reset"><i class="p-icon--close"></i></button>
-  <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search"></i></button>
+  <button type="reset" class="p-search-box__reset"><i class="p-icon--close"></i></button>
+  <button type="submit" class="p-search-box__button"><i class="p-icon--search"></i></button>
 </form>
 <form class="p-search-box">
   <input type="search" class="p-search-box__input" name="search" placeholder="Search" required disabled>
-  <button type="reset" class="p-search-box__reset" alt="reset" disabled><i class="p-icon--close"></i></button>
-  <button type="submit" class="p-search-box__button" alt="search" disabled><i class="p-icon--search"></i></button>
+  <button type="reset" class="p-search-box__reset" disabled><i class="p-icon--close"></i></button>
+  <button type="submit" class="p-search-box__button" disabled><i class="p-icon--search"></i></button>
 </form>
 {% endblock %}
diff --git a/templates/docs/examples/patterns/search-box/navigation-dark.html b/templates/docs/examples/patterns/search-box/navigation-dark.html
@@ -28,8 +28,8 @@
       </ul>
       <form class="p-search-box is-dark">
         <input type="search" class="p-search-box__input" name="search" placeholder="Search" required>
-        <button type="reset" class="p-search-box__reset" alt="reset"><i class="p-icon--close"></i></button>
-        <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search"></i></button>
+        <button type="reset" class="p-search-box__reset"><i class="p-icon--close"></i></button>
+        <button type="submit" class="p-search-box__button"><i class="p-icon--search"></i></button>
       </form>
     </nav>
   </div>

diff --git a/templates/docs/examples/patterns/search-box/navigation.html b/templates/docs/examples/patterns/search-box/navigation.html
@@ -28,8 +28,8 @@
       </ul>
       <form class="p-search-box">
         <input type="search" class="p-search-box__input" name="search" placeholder="Search" required>
-        <button type="reset" class="p-search-box__reset" alt="reset"><i class="p-icon--close"></i></button>
-        <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search"></i></button>
+        <button type="reset" class="p-search-box__reset"><i class="p-icon--close"></i></button>
+        <button type="submit" class="p-search-box__button"><i class="p-icon--search"></i></button>
       </form>
     </nav>
   </div>

diff --git a/templates/docs/examples/templates/maas-docs-grid.html b/templates/docs/examples/templates/maas-docs-grid.html
@@ -46,8 +46,8 @@
   <div class="row">
     <form class="p-search-box u-no-margin--bottom" action="#">
       <input type="search" class="p-search-box__input" name="q" placeholder="Search documentation" required="" />
-      <button type="reset" class="p-search-box__reset" alt="reset"><i class="p-icon--close">Close</i></button>
-      <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search">Search</i></button>
+      <button type="reset" class="p-search-box__reset"><i class="p-icon--close">Close</i></button>
+      <button type="submit" class="p-search-box__button"><i class="p-icon--search">Search</i></button>
     </form>
   </div>
 </section>

diff --git a/templates/docs/examples/templates/maas-docs.html b/templates/docs/examples/templates/maas-docs.html
@@ -123,8 +123,8 @@
     <div class="row">
       <form class="p-search-box u-no-margin--bottom" action="#">
         <input type="search" class="p-search-box__input" name="q" placeholder="Search documentation" required="">
-        <button type="reset" class="p-search-box__reset" alt="reset"><i class="p-icon--close">Close</i></button>
-        <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search">Search</i></button>
+        <button type="reset" class="p-search-box__reset"><i class="p-icon--close">Close</i></button>
+        <button type="submit" class="p-search-box__button"><i class="p-icon--search">Search</i></button>
       </form>
     </div>
   </section>

diff --git a/templates/docs/examples/templates/maas-layout.html b/templates/docs/examples/templates/maas-layout.html
@@ -122,8 +122,8 @@ <h4 class="u-sv-1">Filter by</h4>
     <div class="col-9">
       <form class="p-search-box">
         <input type="search" class="p-search-box__input" name="search" placeholder="Search" required>
-        <button type="reset" class="p-search-box__reset" alt="reset"><i class="p-icon--close"></i></button>
-        <button type="submit" class="p-search-box__button" alt="search"><i class="p-icon--search"></i></button>
+        <button type="reset" class="p-search-box__reset"><i class="p-icon--close"></i></button>
+        <button type="submit" class="p-search-box__button"><i class="p-icon--search"></i></button>
       </form>
       <table aria-label="MAAS table example" class="p-table--mobile-card">
         <thead>