New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove border from subnav dropdowns #2925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 👍
@lyubomir-popov You wanted to do any more small adjustments of is just removing borders for now fine? |
Thanks @bartaz I think this can go in as it is. For a future revision, I'd prefer the drop shadow of submenus to be visible above the horizontal menu, just to create a bit of separation, but with the current markup this is not easily achieved. Something is clipping the box shadow and I couldn't figure out what. But let's leave that for when we do a more thorough update. |
@lyubomir-popov There was a Of course, it's not really visible on dark nav. |
Good work, but personally I liked it better when it didn't have the drop shadows. |
@bartaz as agreed in the standup, please remove the clip. I've talked to @anthonydillon to explain the intricacies there and any bigger changes will be postponed for now as may involve small changes to a handful of related components. |
Done
Removes border from subnav dropdowns
Fixes #2765
QA
./run
Screenshots