Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove border from subnav dropdowns #2925

Merged
merged 2 commits into from Mar 13, 2020
Merged

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Mar 12, 2020

Done

Removes border from subnav dropdowns

Fixes #2765

QA

Screenshots

Screenshot 2020-03-12 at 14 49 40

Screenshot 2020-03-12 at 14 50 02

@webteam-app
Copy link

Copy link
Contributor

@anthonydillon anthonydillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@bartaz
Copy link
Contributor Author

bartaz commented Mar 12, 2020

@lyubomir-popov You wanted to do any more small adjustments of is just removing borders for now fine?

@lyubomir-popov
Copy link
Contributor

lyubomir-popov commented Mar 12, 2020

Thanks @bartaz I think this can go in as it is.

For a future revision, I'd prefer the drop shadow of submenus to be visible above the horizontal menu, just to create a bit of separation, but with the current markup this is not easily achieved. Something is clipping the box shadow and I couldn't figure out what. But let's leave that for when we do a more thorough update.

image

@bartaz
Copy link
Contributor Author

bartaz commented Mar 13, 2020

@lyubomir-popov There was a clip property that was there specifically to hide this top part of shadow. Could be easily removed:

Screenshot 2020-03-13 at 07 29 24

Of course, it's not really visible on dark nav.

@anthonydillon
Copy link
Contributor

Good work, but personally I liked it better when it didn't have the drop shadows.

@lyubomir-popov
Copy link
Contributor

@bartaz as agreed in the standup, please remove the clip. I've talked to @anthonydillon to explain the intricacies there and any bigger changes will be postponed for now as may involve small changes to a handful of related components.

@bartaz bartaz merged commit 748ec31 into canonical:master Mar 13, 2020
@bartaz bartaz deleted the subnav-borders branch March 13, 2020 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing borders from subnav dropdown
4 participants