Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hero pattern docs #5063

Merged
merged 12 commits into from May 7, 2024
Merged

Hero pattern docs #5063

merged 12 commits into from May 7, 2024

Conversation

bartaz
Copy link
Contributor

@bartaz bartaz commented Apr 24, 2024

Done

Adds documentation about hero pattern usage guidelines.

Fixes WD-7710

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

image

@webteam-app
Copy link

@bartaz bartaz added the Documentation 馃摑 Documentation changes or updates label Apr 24, 2024
@bartaz bartaz marked this pull request as ready for review April 24, 2024 14:54
@bartaz bartaz changed the title Hero docs Hero pattern docs Apr 24, 2024
Copy link
Contributor

@chillkang chillkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM馃憤

@bartaz bartaz merged commit 7874c54 into canonical:main May 7, 2024
5 checks passed
@bartaz bartaz deleted the hero-docs branch May 7, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants