Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label line-height on large breakpoint fix #5075

Merged
merged 1 commit into from May 7, 2024

Conversation

dgtlntv
Copy link
Member

@dgtlntv dgtlntv commented May 2, 2024

Done

On the largest breakpoint the labels line-height wasn't set correctly. It was 30.375px when it should be 1.5rem with 18px as 1rem, so 27px. This made the base line drift on large view ports.

QA

  • Open demo
  • Check labels line-height on largest view port

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 馃巵, Breaking Change 馃挘, Bug 馃悰, Documentation 馃摑, Maintenance 馃敤.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

Before

Screenshot 2024-05-02 at 10 21 07

After

Screenshot 2024-05-02 at 10 21 28

@webteam-app
Copy link

Copy link
Contributor

@bartaz bartaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bartaz bartaz merged commit bd970bd into canonical:main May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants