Linux Kernel 6.2 issue #333

dedguy21 · 2023-02-27T15:26:27Z

OS: Arch Linux
Kernel: 6.2
Shell: Bash, Zsh, & Nushell
Terminal: Kitty & Wezterm
Mcfly ver: 0.7.1

I was updated to kernel 6.2 the other day, I noticed when using mcfly, though I could ctrl-r and make a selection, that selection wasn't carried through back to the terminal, so it wouldn't execute. Also, selection would not be carried over to be modified either. I checked the issue across three shells, and two different terminal to be sure.

Rolling back to kernel 6.1 fixed the issue for me. This is more of an FYI in case more people update to kernel 6.2

I haven't traced root issues beyond rolling back.

cantino · 2023-02-28T02:51:55Z

Thanks @dedguy21. Maybe related to #212?

dedguy21 · 2023-02-28T04:56:11Z

More than likely, I'll test and get back to you. Thanks.

Tealk · 2023-02-28T17:32:15Z

I have the same behavior, where can I set this "CONFIG_LEGACY_TIOCSTI"?

comio · 2023-03-01T07:49:45Z

I have the same behavior, where can I set this "CONFIG_LEGACY_TIOCSTI"?

In your kernel .config file. You need to compile from sources.

comio · 2023-03-01T08:09:41Z

Thanks @dedguy21. Maybe related to #212?

Yes. This bug can be marked as duplicate of #212

dedguy21 · 2023-03-01T08:15:24Z

Should I close the issue since it is a repeat of #212?

kjozsa · 2023-03-01T15:37:53Z

I had hit the same issue, also on arch, with kernel 6.2.1-arch1-1. Is this something what should get fixed in mcfly then or in the kernel?

- (all) Enable AppArmor by default. - (all) Complete CONFIG_LSM by upstream template. - (all) Run dev-sort-config.sh. - (all) Enable CONFIG_LEGACY_TIOCSTI to fix issue with McFly. [1] FIXME: CONFIG_LEGACY_TIOCSTI has a known security flaw and upstream recommends disabling by default. [2] But this breaks userspace, which should enrage Linus Torvalds, and possibly others. Make most of us happy. Ref [1]: cantino/mcfly#333 Ref [2]: https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=tiocsti

- (all) Enable AppArmor by default. - (all) Complete CONFIG_LSM by upstream template. - (all) Run dev-sort-config.sh. - (all) Enable CONFIG_LEGACY_TIOCSTI to fix issue with McFly. [1] - Bump zfs PKGBREAK to <= 2.2.0. FIXME: CONFIG_LEGACY_TIOCSTI has a known security flaw and upstream recommends disabling by default. [2] But this breaks userspace, which should enrage Linus Torvalds, and possibly others. Make most of us happy. Ref [1]: cantino/mcfly#333 Ref [2]: https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=tiocsti

somepaulo · 2023-03-04T15:02:17Z

Just updated to 6.2.2-arch1-1, issue persists.

dedguy21 · 2023-03-05T03:38:46Z

FYI:
An arch maintainer advised me that they are definitely not going to make CONFIG_LEGACY_TIOCSTI available going forward as it poses a potential security risk.

kauruus · 2023-03-05T09:40:01Z

There is a bug in the kernel that prevents me to set dev.tty.legacy_tiocsti, so I make a simple kernel module to re-enable TIOCSTI.

dedguy21 · 2023-03-05T23:13:27Z

If this works on zsh as long as zsh is the login, then I'll make the switch.

Thanks. I'll close this dup issue.

cantino · 2023-03-06T03:27:30Z

It might be worth leaving this open for other people to find.

kjozsa · 2023-03-06T13:37:38Z

I don't even see how this issue will get resolved. Will bash work around the new kernel limitation? Will mcfly adapt and change the way bash is being used? Will the kernel come up with something which allows again things to work as intented?

Meanwhile, I made the switch to fish, to be able to use the latest kernel while keeping mcfly - so far I'm grateful for getting pushed into this direction.

a-dekker · 2023-03-12T11:52:36Z

https://github.com/dvorka/hstr/ is also affected by this, see dvorka/hstr#478.
https://github.com/junegunn/fzf is not affected.

I can confirm using kauruus kernel module does help (#333 (comment)).
And in dvorka/hstr#478 (comment) an attempt is made to fix hstr in a "fzf way".

But so far I did not see McFly having this issue addressed, so in the mean time we need workarounds like the kernel module or alternative tools/shells.

comio · 2023-03-12T13:12:36Z

I suggest this workaround modifying the bind script:

Create a temp file
Pass the filename to mcfly executable via a proper option
Store the search result to the provided temporary file;
source the file and update READLINE_LINE variable accordantly
Remove the temporary file

McFly should support a special option to pass and store the search result.

my 2EurCents.

ciao

luigi

a-dekker · 2023-03-15T07:59:39Z

The bug that the parameter CONFIG_LEGACY_TIOCSTI cannot be set has been fixed in recent 6.2 kernel releases dvorka/hstr#478 (comment)

dedguy21 · 2023-03-16T10:04:09Z

The bug that the parameter CONFIG_LEGACY_TIOCSTI cannot be set has been fixed in recent 6.2 kernel releases dvorka/hstr#478 (comment)

I ran the "# sysctl -w dev.tty.legacy_tiocsti=1 " and it works, but rookie question, where do we put the command so we don't have to run it manually every start up?

Not /etc/environment, and the local .bash_profile doesn't have permisson either. What is a good way to automate the process without getting permission failures?

darthShadow · 2023-03-16T10:10:53Z

Any sysctl parameters generally go in a custom file in /etc/sysctl.d

dedguy21 · 2023-03-16T12:54:16Z

Any sysctl parameters generally go in a custom file in /etc/sysctl.d

Works like a charm. Thanks 🙏

jkseppan · 2023-04-02T18:40:57Z

@comio wrote:

I suggest this workaround modifying the bind script:

Create a temp file

Pass the filename to mcfly executable via a proper option

Store the search result to the provided temporary file;

source the file and update READLINE_LINE variable accordantly

Remove the temporary file

Here's a patch that implements something like this, but only for replacing the edit buffer. What I couldn't get to work was running the command properly. You could insert it into history with history -s, echo the prompt and command to make it look like you ran it, and write it into a file and source the file, but even then any error status returned by the command does not get conveyed to the shell. I guess this is because it gets called through a readline binding, so it looks to the shell like an editing operation instead of executing a command.

There are various hacks in the answers to this Unix & Linux Stackexchange question that might be adapted. Personally I'm fine with pressing Enter another time after choosing the command.

mcfly.bash.patch

RHOOPH · 2023-04-20T14:10:02Z

@dedguy21 @darthShadow Can you please explain the steps to put custom file in etc/sysctl.d and have it run on boot.

dedguy21 · 2023-04-20T14:43:27Z

@RHOOPH

You should have a directory:
/etc/sysctl.d/

In that directory is where you save your file.

Example:

vim 10_legacy_tiocsti.conf

Then write

legacy_tiocsti=1 in the file

Save to /etc/sysctl.d/10_legacy_tiocsti.conf

somepaulo · 2023-05-17T08:50:37Z

Then write

legacy_tiocsti=1 in the file

This should read dev.tty.legacy_tiocsti=1 actually.

benyaminl · 2023-06-07T02:00:33Z

@somepaulo for somereason, /etc/sysctl.d seems doesn't work on new kernel 6.3.x, are they dropping it? Manual set using

sudo sysctl -w dev.tty.legacy_tiocsti=1

Still work, but not the boot .conf file.

any idea why ? Or it's specific to fedora only?

Dlinuigh · 2024-03-17T08:52:24Z

@somepaulo for somereason, /etc/sysctl.d seems doesn't work on new kernel 6.3.x, are they dropping it? Manual set using
sudo sysctl -w dev.tty.legacy_tiocsti=1
Still work, but not the boot .conf file.

any idea why ? Or it's specific to fedora only?

Work on arch, with kernel 6.8.1.

cantino · 2024-04-28T23:23:59Z

I'm open to PRs that fix this if anyone sees a path forward.

cantino · 2024-05-26T03:16:40Z

It'd be great if bash users could test #416

digikata · 2024-05-28T20:56:37Z

building and using #416 works for me on a linux 6.8 kernel that was broken w/ bash on the stable release.

cantino · 2024-06-01T03:55:43Z

Should hopefully be fixed by #416 and https://github.com/cantino/mcfly/releases/tag/v0.9.0.

cantino · 2024-06-03T04:28:49Z

I believe this is fixed! Please re-open if not.

dedguy21 closed this as completed Mar 5, 2023

cantino reopened this Mar 6, 2023

cantino mentioned this issue Apr 6, 2023

Mcfly not working on Fedora / KDE anymore #344

Closed

somepaulo mentioned this issue May 17, 2023

Typing to console does not work #360

Closed

cantino pinned this issue Jun 3, 2023

cantino mentioned this issue Apr 28, 2024

Panic in src/fake_typer.rs - broken edit and run commands #404

Closed

cantino mentioned this issue Apr 28, 2024

mcfly stopped working (kernel issue) #371

Closed

nuke-web3 mentioned this issue May 19, 2024

Installing mcfly on Ubuntu 24.04 doesn't bind CTRL+R and "mcfly search" throws error #409

Closed

cantino mentioned this issue May 26, 2024

Command is not passed back to bash when connected over SSH #192

Open

cantino closed this as completed Jun 3, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Linux Kernel 6.2 issue #333

Linux Kernel 6.2 issue #333

dedguy21 commented Feb 27, 2023 •

edited

cantino commented Feb 28, 2023

dedguy21 commented Feb 28, 2023

Tealk commented Feb 28, 2023

comio commented Mar 1, 2023

comio commented Mar 1, 2023

dedguy21 commented Mar 1, 2023

kjozsa commented Mar 1, 2023

somepaulo commented Mar 4, 2023

dedguy21 commented Mar 5, 2023

kauruus commented Mar 5, 2023

dedguy21 commented Mar 5, 2023

cantino commented Mar 6, 2023

kjozsa commented Mar 6, 2023

a-dekker commented Mar 12, 2023

comio commented Mar 12, 2023

a-dekker commented Mar 15, 2023

dedguy21 commented Mar 16, 2023

darthShadow commented Mar 16, 2023

dedguy21 commented Mar 16, 2023

jkseppan commented Apr 2, 2023 •

edited

RHOOPH commented Apr 20, 2023

dedguy21 commented Apr 20, 2023

somepaulo commented May 17, 2023

benyaminl commented Jun 7, 2023 •

edited

Dlinuigh commented Mar 17, 2024

cantino commented Apr 28, 2024

cantino commented May 26, 2024

digikata commented May 28, 2024

cantino commented Jun 1, 2024

cantino commented Jun 3, 2024

Linux Kernel 6.2 issue #333

Linux Kernel 6.2 issue #333

Comments

dedguy21 commented Feb 27, 2023 • edited

cantino commented Feb 28, 2023

dedguy21 commented Feb 28, 2023

Tealk commented Feb 28, 2023

comio commented Mar 1, 2023

comio commented Mar 1, 2023

dedguy21 commented Mar 1, 2023

kjozsa commented Mar 1, 2023

somepaulo commented Mar 4, 2023

dedguy21 commented Mar 5, 2023

kauruus commented Mar 5, 2023

dedguy21 commented Mar 5, 2023

cantino commented Mar 6, 2023

kjozsa commented Mar 6, 2023

a-dekker commented Mar 12, 2023

comio commented Mar 12, 2023

a-dekker commented Mar 15, 2023

dedguy21 commented Mar 16, 2023

darthShadow commented Mar 16, 2023

dedguy21 commented Mar 16, 2023

jkseppan commented Apr 2, 2023 • edited

RHOOPH commented Apr 20, 2023

dedguy21 commented Apr 20, 2023

somepaulo commented May 17, 2023

benyaminl commented Jun 7, 2023 • edited

Dlinuigh commented Mar 17, 2024

cantino commented Apr 28, 2024

cantino commented May 26, 2024

digikata commented May 28, 2024

cantino commented Jun 1, 2024

cantino commented Jun 3, 2024

dedguy21 commented Feb 27, 2023 •

edited

jkseppan commented Apr 2, 2023 •

edited

benyaminl commented Jun 7, 2023 •

edited