Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mode for chaining multiple commands #327

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

YuviTz1
Copy link

@YuviTz1 YuviTz1 commented Jan 27, 2023

Added a new mode ChainCommands which can be selected using Shift + Tab.
Further pressing Shift + Tab will chain commands.
Pressing Tab will shift to edit mode and enter key can be used to execute the formed chain.
Possible implementation for #294.
Do tell me if something needs to be changed :)

@cantino
Copy link
Owner

cantino commented Feb 26, 2023

Cool idea @YuviTz1! It seems to work for me.

I think when you first hit shift + tab, whatever command you're on should be added to the chain right away. Seems like you have to hit it twice right now.

Also, how do you remove something from the chain?

The highlight color is very hard to read though:

image

@YuviTz1
Copy link
Author

YuviTz1 commented Mar 4, 2023

Update:

Going into chain mode adds selected command to the chain.

Press F3 to remove commands from the chain. However do note that previously executed chains will be treated as a single command in the new chain when removing. Example:
image

Any suggestions for Highlight color?

@cantino
Copy link
Owner

cantino commented Mar 7, 2023

Needs to be rebased.

@YuviTz1
Copy link
Author

YuviTz1 commented Mar 11, 2023

I have rebased the changes but now if the command chain takes up more than one line in the menubar, Only the first line updates successfully when removing commands from the chain for example-
image
Here, after removing the last command from the chain, 2nd line of menubar is not refreshed.
This behaviour was not present before rebasing.

@cantino
Copy link
Owner

cantino commented Mar 18, 2023

I think the way that we cleared lines got changed with @jtschuster's upgrade. Do you want to either truncate at the screen width or make this show up on its own line below the header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants