Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add package description #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

blaggacao
Copy link

@blaggacao blaggacao commented May 2, 2023

fix #16

However, there may be actually more elegant ways to do that as part of buildNodeModule based on some available metadata from package.json & co...

@blaggacao blaggacao requested a review from olebedev as a code owner May 2, 2023 17:43
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@olebedev
Copy link
Collaborator

olebedev commented May 3, 2023

However, there may be actually more elegant ways to do that as part of buildNodeModule based on some available metadata from package.json & co...

Hello! I recommend automating the annotation process for any package, rather than performing it manually for the js2nix package. Would you be open to trying this approach as submit a PR? :)

@blaggacao
Copy link
Author

Would you be open to trying this approach as submit a PR? :)

Yep, I can give it a shot tomorrow:-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No meta.description
3 participants